Add the ability to deal with remote ecore URI #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce a kind of switch that give the ability to fetch .ecore/.xmi files from a remote URI. This does not implies modifications to the pyecoregen CLI options. When a remote URI is discovered (i.e, that begins with 'http(s)://', the URI implementation is simply changed from the URI to HttpURI from pyecore.
moltob
reviewed
Jun 7, 2017
pyecoregen/cli.py
Outdated
| @@ -53,10 +54,19 @@ def configure_logging(parsed_args): | |||
| ) | |||
|
|
|||
|
|
|||
| def select_uri_implementation(ecore_model_path): | |||
| """Select the right URI implementation regarding the Ecore model path schema.""" | |||
| url_pattern = re.compile('^http(s)?://.*') | |||
There was a problem hiding this comment.
Just a minor: I suggest to make this a module level constant URL_PATTERN, so the compilation will happen only once during import.
Feel free to merge yourself, since I am offline for the rest of the day.
Thanks for leeting me know about the change,
Mike
|
I modified the commit as requested. I wasn't sure to put the pattern compilation as global var as the Also, I only add the PR for later (later later) review, you don't need to review it right away ;), this can totally wait until you go back from your vacations of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduce a kind of switch that give the ability to fetch .ecore/.xmi files from a remote URI. This does not implies modifications to the pyecoregen CLI options.
When a remote URI is discovered (i.e, that begins with
http(s)://, the URI implementation is simply changed fromURItoHttpURIfrompyecore.resources.resource.