Don't crash when the query_params kwarg to send_request is omitted. Fix

#173.

Keep the null value of the kwarg as None for two reasons: (1) so we don't invalidate the docstring which says we can pass None and (2) because mutables as kwarg default values are asking for trouble.

docs/source/changelog.rst

@@ -2,6 +2,12 @@
 Changelog
 =========
 
+v1.2.4 (2015-05-21)
+-------------------
+* Don't crash when the ``query_params`` kwarg is omitted from calls to
+  ``send_request()``.
+
+
 v1.2.3 (2015-04-17)
 -------------------
 * Make ``delete_all_indexes()`` work.

pyelasticsearch/__init__.py

@@ -14,7 +14,7 @@
 __all__ = ['ElasticSearch', 'ElasticHttpError', 'Timeout', 'ConnectionError',
            'ElasticHttpNotFoundError', 'IndexAlreadyExistsError', 'BulkError',
            'InvalidJsonResponseError', 'bulk_chunks']
-__version__ = '1.2.3'
+__version__ = '1.2.4'
 __version_info__ = tuple(__version__.split('.'))
 
 get_version = lambda: __version_info__

pyelasticsearch/client.py

@@ -234,6 +234,8 @@ def send_request(self,
         :arg query_params: A map of querystring param names to values or
             ``None``
         """
+        if query_params is None:
+            query_params = {}
         path = self._join_path(path_components)
 
         # We wrap to use pyelasticsearch's exception hierarchy for backward

pyelasticsearch/tests/client_tests.py

@@ -390,6 +390,11 @@ def test_percolate(self):
         result = self.conn.percolate('test-index', 'test-type', document)
         self.assert_result_contains(result, {'matches': []})
 
+    def test_send_request_without_query_params(self):
+        """Demonstrate that omitting the query_params kwarg to send_request
+        doesn't try to call iteritems() on None."""
+        self.conn.send_request('GET', [])
+
 
 class SearchTestCase(ElasticSearchTestCase):
     def setUp(self):