Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fish 2.6.0 fixes setenv implementation, which breaks pyenv-virtualenv usage #216

Closed
daogilvie opened this issue Jun 8, 2017 · 2 comments
Closed

Fish 2.6.0 fixes setenv implementation, which breaks pyenv-virtualenv usage #216

daogilvie opened this issue Jun 8, 2017 · 2 comments

Comments

@daogilvie
Copy link
Contributor

daogilvie commented Jun 8, 2017 •
edited

This problem has already been fixed in regular pyenv head (but not the latest release 1.0.10), and is a simple change to use the set -gx command where there is currently setenv.

Symptom:
Script generated by pyenv virtualenv init -, when executed on fish 2.6.0, errors out with setenv: Too many arguments`

Confirmed on:
fish, version 2.6.0-63-g352cea16

Discussed here: fish-shell/fish-shell#4103

PR coming shortly
@daogilvie daogilvie mentioned this issue Jun 8, 2017
Closed
@blueyed
Copy link
Collaborator

blueyed commented Jun 8, 2017

#215 fixes this, but has failing tests.

@daogilvie
Copy link
Contributor Author

Noted, apologies for timewasting. Will see if I can contribute along those lines, continuing under #215

@daogilvie daogilvie mentioned this issue Jun 8, 2017
Merged
blueyed pushed a commit that referenced this issue Jun 8, 2017
@daogilvie @blueyed
fish: use "set -gx" instead of "setenv" (#218)
862be21 
Use `set -gx` instead of `setenv` for fish shell.

Fix test "activate if the first virtualenv is a virtualenv": it was asserting
the output was of bash form, but not specifying that in the test — it now does.

Fixes #216.
@herrbischoff herrbischoff mentioned this issue Jun 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blueyed @daogilvie