cd: <symlink target file>: Not a directory

[HQJaTu]

File pyenv assumes, that it can follow symlinks in abs_dirname():

  abs_dirname() {
    local path="$1"

    # Use a subshell to avoid changing the current path
    (
    while [ -n "$path" ]; do
      cd "${path%/*}"
      local name="${path##*/}"
      path="$(resolve_link "$name" || true)"
    done

    pwd
    )
  }

However, the target file can be a symlink, and it cannot be followed.

Example from Ansible. Listing of ansible/bin/:

    ansible
    ansible-playbook -> ansible

Executing ~/ansible/bin/ansible-playbook will work, but during it a ~/.pyenv/libexec/pyenv: line 44: cd: ansible: Not a directory is emitted.

A suggested fix would be:

      path="$(test -d "$name" && resolve_link "$name" || true)"

... to test if the destination is a directory that can be cdd into.
If yes, follow that. If not, stop iterating without emitting errors.

[webknjaz]

Haha 🤣
I've just spotted this yesterday, did debugging today and also with ansible-test script and going to prepare somewhat similar patch :)

[webknjaz]

Looks like there's a test for it and it's broken https://travis-ci.org/pyenv/pyenv/jobs/353851590#L523-L529

[webknjaz]

ref: #379, #404

[webknjaz]

Okay.. test is not broken, but the fix is imperfect

[webknjaz]

Got a solution: resolve pwd with --follow when returning

[webknjaz]

Pipeline succeeds, dunno how to catch this with a test though.

[webknjaz]

Ping @joshfriend @yyuu 🔔
I've fixed it, please review the PR #1120.

[blueyed]

Closing as duplicate of #580.