Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'sed: RE error: illegal byte sequence' #1714

Merged
merged 1 commit into from Feb 17, 2021
Merged

Conversation

tuzi3040
Copy link
Contributor

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR
    Fix 'sed: RE error: illegal byte sequence'
    by unsetting LC_ALL and passing LC_CTYPE=C to sed.

Tests

  • My PR adds the following unit tests (if any)

... by unsetting `LC_ALL` and passing `LC_CTYPE=C` to `sed`.

This commit fixes issue pyenv#1454.
@joshfriend joshfriend merged commit d51999a into pyenv:master Feb 17, 2021
@tuzi3040 tuzi3040 deleted the patch-1 branch February 18, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants