Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: fix summary for repeated/binary commands #1455

Closed
wants to merge 1 commit into from

Conversation

unrevre
Copy link

@unrevre unrevre commented Nov 12, 2019

fix fcf539e: 'commands' command is repeated; commands which call binary
executables (e.g. pyenv-realpath.dylib) are also grabbed, which cause
help message parsing to fail. depending on the system locale, sed may
also emit an error.

remove extra 'commands' command; restrict help message parsing to files
of mime-type 'text/*t'.

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Tests

  • My PR adds the following unit tests (if any)

fix fcf539e: 'commands' command is repeated; commands which call binary
executables (e.g. pyenv-realpath.dylib) are also grabbed, which cause
help message parsing to fail. depending on the system locale, sed may
also emit an error.

remove extra 'commands' command; restrict help message parsing to files
of mime-type 'text/*'.
@ericvw
Copy link

ericvw commented Nov 13, 2019

This closes #1454.

@zed
Copy link
Contributor

zed commented Nov 15, 2019

#1461 fixes the duplicate commands summary while keeping it at the top of the help output.

@native-api
Copy link
Member

Superceded by #1525 , #1714

@native-api native-api closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants