Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GNU Readline 8.0 #1329

Merged
merged 1 commit into from Apr 9, 2019
Merged

Use GNU Readline 8.0 #1329

merged 1 commit into from Apr 9, 2019

Conversation

yyuu
Copy link
Contributor

@yyuu yyuu commented Apr 9, 2019

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • This is a fix to its core build feature
  • x ] Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
    • The feature isn't derived from the upstream
  • My PR addresses the following pyenv issue (if any)
    • n/a

Description

  • Here are some details about my PR

Update GNU Readline version to be installed when brew's package is not available.

Tests

  • My PR adds the following unit tests (if any)
    • n/a

@yyuu yyuu merged commit 2891972 into master Apr 9, 2019
@yyuu yyuu deleted the yy-mac-readline-8.0 branch April 9, 2019 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant