Mention log file if an error happened before building, too #1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Prerequisite
N/A -- bugfix
N/A -- the code in question is not present in rbenv
Description
When a build fails, mention log file and its contents regardless of whether
$BUILD_PATH
existsTests
The current tests seem to only be testing public functionality while
build_failed()
is private. Should I add a test for it? Is it okay to test it directly? If not, which endpoint should I test it via?