Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention log file if an error happened before building, too #1537

Merged
merged 1 commit into from
May 26, 2021

Conversation

native-api
Copy link
Member

@native-api native-api commented Feb 19, 2020

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
      N/A -- bugfix
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
      N/A -- the code in question is not present in rbenv
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR
    When a build fails, mention log file and its contents regardless of whether $BUILD_PATH exists

Tests

  • My PR adds the following unit tests (if any)
    The current tests seem to only be testing public functionality while build_failed() is private. Should I add a test for it? Is it okay to test it directly? If not, which endpoint should I test it via?

@native-api native-api merged commit ca20324 into pyenv:master May 26, 2021
@native-api native-api deleted the mention_log branch May 26, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant