Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miniconda3 4.8.2, 4.8.3, & 4.9.2 #1763

Merged
merged 8 commits into from Jan 29, 2021
Merged

Conversation

pc-fmarin
Copy link
Contributor

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Update miniconda 4.8.2, 4.8.3, & 4.9.2 w/ py7, py8, and py9 versions

Tests

  • My PR adds the following unit tests (if any)

Copy link
Member

@anton-petrov anton-petrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All versions is up to date.

Copy link
Contributor

@yyuu yyuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the first glance, I was surprised with the naming of those new definition files (e.g. use of underscore), however, it seems like it's just following the naming convention of upstream as they are. I think, just using the upstream naming would be good and intuitive for most uses. Any opinions/insights? 🤔

@anton-petrov
Copy link
Member

At the first glance, I was surprised with the naming of those new definition files (e.g. use of underscore), however, it seems like it's just following the naming convention of upstream as they are. I think, just using the upstream naming would be good and intuitive for most uses. Any opinions/insights? 🤔

I fully agree that file naming should be standard, a general approach should be followed, we shouldn't use underscores in filenames, IMHO

Copy link
Member

@anton-petrov anton-petrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to develop and discuss a file naming standard.

@anton-petrov anton-petrov self-requested a review January 10, 2021 15:02
Copy link
Member

@anton-petrov anton-petrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth changing the naming of the files a bit, like miniconda3-3.7-4.8.3? Where 3.7 is the python version, 4.8.3 - version of miniconda.

@anton-petrov anton-petrov added the needs attention needs team attention, response provided label Jan 18, 2021
@anton-petrov anton-petrov merged commit 982c5b3 into pyenv:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs attention needs team attention, response provided pr: new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants