Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable coreutils on M1 Apple Silicon with arm64 (#2020)" #2212

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

native-api
Copy link
Member

@native-api native-api commented Jan 8, 2022

This reverts commit 90d0d20.

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

After further consideration, we've decided to remove this workaround:

  • It only has an effect if the user has added gnubin from Homebrew Coreutils to PATH which is an unsupported setup
  • It was intended to be applied only to a few select 3.8 and 3.9 versions that officially support Apple Silicon and only fail with Homebrew Coreutils in PATH because they have config.* from a too old version of Autoconf that doesn't support the Arm64 arch -- but

Tests

  • My PR adds the following unit tests (if any)

@native-api
Copy link
Member Author

@yackrru Be advised that we're removing this workaround, see above for the reasons.

@native-api native-api merged commit 971397d into pyenv:master Jan 8, 2022
@native-api native-api deleted the revert_coreutils_workaround branch January 8, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant