Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Fish PATH update #2449

Merged
merged 3 commits into from Sep 6, 2022
Merged

docs: update Fish PATH update #2449

merged 3 commits into from Sep 6, 2022

Conversation

gregorias
Copy link
Contributor

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

The original instructions were added 2 years ago in 0f2d659. Since then, Fish released a more declarative instruction for this operation, which is now the recommended way of manipulating PATH in Fish.

README.md Outdated Show resolved Hide resolved
The original instructions were added 2 years ago in 0f2d659. Since then, [Fish released](https://github.com/fish-shell/fish-shell/releases/tag/3.2.0) [a more declarative instruction for this operation](https://fishshell.com/docs/current/cmds/fish_add_path.html), which is now the recommended way of manipulating `PATH` in Fish.
@native-api native-api merged commit 6a104f6 into pyenv:master Sep 6, 2022
dand-oss pushed a commit to dand-oss/pyenv that referenced this pull request Sep 7, 2022
The original instructions were added 2 years ago in pyenv@0f2d659. Since then, [Fish released](https://github.com/fish-shell/fish-shell/releases/tag/3.2.0) [a more declarative instruction for this operation](https://fishshell.com/docs/current/cmds/fish_add_path.html), which is now the recommended way of manipulating `PATH` in Fish.
0xkag pushed a commit to 0xkag/pyenv that referenced this pull request Feb 19, 2023
The original instructions were added 2 years ago in pyenv@0f2d659. Since then, [Fish released](https://github.com/fish-shell/fish-shell/releases/tag/3.2.0) [a more declarative instruction for this operation](https://fishshell.com/docs/current/cmds/fish_add_path.html), which is now the recommended way of manipulating `PATH` in Fish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants