Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patches for 3.7.14 needed for Apple Silicon #2463

Merged
merged 1 commit into from Sep 15, 2022

Conversation

samdoran
Copy link
Contributor

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)
    • None

Description

Mostly the same patches from 3.7.13 are needed for 3.7.14 on Apple Silicon.

Tests

  • My PR adds the following unit tests (if any)

@native-api
Copy link
Member

Could you also port patches for the recently-added 3.8.14 and 3.9.14?

@samdoran
Copy link
Contributor Author

I'd be happy to, but I don't think those patches are needed for 3.8.14 and 3.9.14. I looked through the CPython source and the changes are already present in those versions and the need for a VARIADIC flag was solved in another way (based on reading the comments in the source).

Also, I've installed both 3.8.14 and 3.9.14 and ctypes compiled fine.

@native-api native-api merged commit cfe684e into pyenv:master Sep 15, 2022
@samdoran samdoran deleted the 3.7.14-arm-patches branch September 15, 2022 15:35
@samdoran
Copy link
Contributor Author

Thank you for merging!

native-api added a commit that referenced this pull request Sep 15, 2022
@native-api native-api mentioned this pull request Sep 22, 2022
5 tasks
0xkag pushed a commit to 0xkag/pyenv that referenced this pull request Feb 19, 2023
0xkag pushed a commit to 0xkag/pyenv that referenced this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants