-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation error when building OpenSSL 1.1.1q in MacOS 11+ for 3.9.15 and 3.8.15 #2520
Conversation
@@ -8,3 +8,5 @@ | |||
/src/*.o | |||
/bats/ | |||
/default-packages | |||
.idea | |||
*.un~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.idea is a directory created by pycharm
*.un~ is a lockfile created by vim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extending project's .gitignore
with personal OS/tooling-related files and paths is usually not recommended practice.
Especially in this exact case, it is totally unrelated to the patch you are providing.
I suggest you configuring global .gitignore
file for your workstation:
https://adamj.eu/tech/2022/11/06/git-set-up-a-global-ignore-file/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think IDEA/Pycharm and Vim are used widely enough to warrant adding.
It's okay to address additional concerns in a PR (as long as it's within reason, of course), but then each concern needs to be in its own commit (see the contribution giude).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twangboy Could you please restructure the commits as per the contribution giude, or move the gitignore part to another PR?
aa244bf
to
70141e3
Compare
70141e3
to
3bfaa33
Compare
Make sure you have checked all steps below.
Prerequisite
Description
Python updated openssl to version 1.1.1q in 3.8.15, 3.9.15 and 3.11. Python 3.10.7 is at 1.1.1o.
The following PR added a patch for building openssl 1.1.1q on 3.11 but not for 3.8.15 and 3.9.15.
Fix compilation error when building OpenSSL 1.1.1q in MacOS 11+ #2500
This applies the openssl 1.1.1q patches to the 3.8.15 and 3.9.15 builds of python.
Tests
N/A