Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-bash output while detecting shell #2561

Merged
merged 6 commits into from
Dec 24, 2022

Conversation

ianchen-tw
Copy link
Contributor

@ianchen-tw ianchen-tw commented Dec 14, 2022

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.

Description

  • Here are some details about my PR
    pyenv-init --detect-shell will output non-bash script result while configuration files are not supported, since placeholder values are used for explanation.

Tests

Test for the new function.

Copy link
Member

@native-api native-api left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyenv-init --detect-shell will output non-bash script result while configuration files are not supported, since placeholder values are used for explanation.

Maybe my English is not good enough, but I've no idea what this means or how it explains the purpose and necessity of the added function.

Perhaps if you could update the Pyenv-Installer PR to show how it is supposed to be used?

@native-api
Copy link
Member

Perhaps if you could update the Pyenv-Installer PR to show how it is supposed to be used?

Okay, you already did. Let's see then...

libexec/pyenv-init Outdated Show resolved Hide resolved
@native-api native-api merged commit f897c50 into pyenv:master Dec 24, 2022
dand-oss pushed a commit to dand-oss/pyenv that referenced this pull request Jan 4, 2023
Co-authored-by: Ivan Pozdeev <vano@mail.mipt.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants