Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray newline after python-build installation #2566

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

tklauser
Copy link
Contributor

@tklauser tklauser commented Dec 20, 2022

This makes the output look slightly odd:

$ pyenv install 3.10.9
python-build: use openssl@1.1 from homebrew
python-build: use readline from homebrew
Downloading Python-3.10.9.tar.xz...
-> https://www.python.org/ftp/python/3.10.9/Python-3.10.9.tar.xz
Installing Python-3.10.9...
python-build: use readline from homebrew
python-build: use zlib from xcode sdk
Installed Python-3.10.9 to /Users/tklauser/.pyenv/versions/3.10.9

$

Remove the stray newline to match other pyenv commands.

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)
    • None

Description

  • Here are some details about my PR
    • Fixes a stray newline at the end of pyenv install ... when installing using python-build.

Tests

  • My PR adds the following unit tests (if any)
    • None

This makes the output look slightly odd:

```
$ pyenv install 3.10.9
python-build: use openssl@1.1 from homebrew
python-build: use readline from homebrew
Downloading Python-3.10.9.tar.xz...
-> https://www.python.org/ftp/python/3.10.9/Python-3.10.9.tar.xz
Installing Python-3.10.9...
python-build: use readline from homebrew
python-build: use zlib from xcode sdk
Installed Python-3.10.9 to /Users/tklauser/.pyenv/versions/3.10.9

$
```

Remove the stray newline to match other pyenv commands.
@native-api native-api merged commit ff93c58 into pyenv:master Dec 20, 2022
@tklauser tklauser deleted the python-build-stray-newline branch December 20, 2022 22:06
dand-oss pushed a commit to dand-oss/pyenv that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants