Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Miniforge/Mambaforge versions (4.10.2-0 - 22.9.0-3) #2591

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

smcgivern
Copy link
Contributor

Make sure you have checked all steps below.

This is the result of running the script in #2560.

Test script (with untracked files):

#!/usr/bin/bash

set -eu

for f in $(git ls-files --others --exclude-standard -- plugins/python-build/share); do
    bin/pyenv install $(basename $f) &> /dev/null
    bin/pyenv local $(basename $f)
    echo "Testing $(basename $f)"
    bin/pyenv exec python3 -V
    echo
    bin/pyenv uninstall -f $(basename $f) &> /dev/null
done

Output:

Testing mambaforge-22.9.0-0
Python 3.10.6

Testing mambaforge-22.9.0-1
Python 3.10.6

Testing mambaforge-22.9.0-3
Python 3.10.8

Testing mambaforge-4.10.2-0
Python 3.9.5

Testing mambaforge-4.10.3-0
Python 3.9.5

Testing mambaforge-4.10.3-1
Python 3.9.5

Testing mambaforge-4.10.3-2
Python 3.9.6

Testing mambaforge-4.10.3-3
Python 3.9.6

Testing mambaforge-4.10.3-4
Python 3.9.6

Testing mambaforge-4.10.3-5
Python 3.9.6

Testing mambaforge-4.10.3-6
Python 3.9.7

Testing mambaforge-4.10.3-7
Python 3.9.7

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Tests

  • My PR adds the following unit tests (if any)

@smcgivern smcgivern marked this pull request as ready for review January 11, 2023 16:40
* )
{ echo
colorize 1 "ERROR"
echo ": The binary distribution of Miniforge is not available for $(anaconda_architecture 2>/dev/null || true)."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@native-api native-api merged commit b9a27af into pyenv:master Jan 11, 2023
@native-api native-api changed the title Backfill missing {mini,mamba}forge versions Add missing Miniforge/Mambaforge versions (4.10.2-0 - 22.9.0-3) Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants