Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using dependencies from Ports in FreeBSD that are not searched with pkg-config #2593

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

native-api
Copy link
Member

@native-api native-api commented Jan 13, 2023

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Reworked #2586 . It turns out, only some deps are searched by CPython's Configure with pkg-config. At least Readline and Sqlite3 aren't (this is fixed for readline in 3.12.0a1 and for sqlite3 in 3.11.0a3).

Tests

  • My PR adds the following unit tests (if any)
  • Tests for added logic

Surprisingly, CPython doesn't search these with pkg-config
This is fixed upstream in 3.12.0a1
@native-api native-api merged commit 83619f3 into pyenv:master Jan 13, 2023
@native-api native-api deleted the fix_freebsd branch January 13, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readline issues on new install of FreeBSD 13.1
1 participant