Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong libpython being linked to in MacOS #2596

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

native-api
Copy link
Member

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

The comment at

# The ld on Darwin embeds the full paths to each dylib by default
said that rpath does not need to be set in MacOS.
Looks like this is not the case anymore: bin/python was linking to the stock Apple's libpython without it.

@yyuu , as the person who authored 0d85193, do you remember anything? Maybe rpath only needs to be added to PYTHON_LDFLAGS?

Tests

  • My PR adds the following unit tests (if any)
    N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing 2.7.18 on a macOS with existing system 2.7.16 will actually yield 2.7.16
1 participant