Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-27987 for v3.5.10 and v3.6.15: align by 16bytes on 64bit platforms #2630

Merged
merged 4 commits into from
Feb 26, 2023

Conversation

chaimleib
Copy link
Contributor

Description

This resolves an error encountered on x86_64 for python versions 3.5.10 and 3.6.15 where ./python -c 'import ctypes' causes an immediate segfault. Also, when pyenv install runs ./python -E -m ensurepip --upgrade --root=/, this imports ctypes and also causes a segfault.

The segfault causes pyenv install 3.5.10 and the same for 3.6.15 to fail and not install.

This bug was resolved in bpo-27987 for the v2.7 branch and v3.7 branch and later. (Note that in the conversation, although one of the patches was reverted, the revert was reverted at the end.) This PR backports those patches for 3.5.10 and 3.6.15, which were left unfixed. These patches would likely not be accepted upstream because 3.5 and 3.6 are EOL.

Despite these versions being EOL, I was interested for old times sake. Also, the test harness for chaimleib/intervaltree lists these versions, among others, as test targets.

Tests

set -e
for v in 3.5.10 3.6.15; do
  pyenv install $v
  pyenv global $v
  python --version
  python -c 'import ctypes'
done

@native-api
Copy link
Member

native-api commented Feb 24, 2023

This looks like a solution for some old issues -- #2141 and #2046!

@native-api
Copy link
Member

native-api commented Feb 24, 2023

The errors are because 3.5.10 is incompatible with MacOS 11+ (3.6.15 has downstream patches that make it compatible). Going to fix that? We're fine either way since this is not an additional breakage.

…configure with recent versions of clang. (GH-28845) (GH-31890)
@chaimleib chaimleib force-pushed the fix-bpo-27987-on-eol-pythons branch 2 times, most recently from 0eac103 to 6bec7a5 Compare February 24, 2023 21:57
@native-api native-api merged commit 276ce32 into pyenv:master Feb 26, 2023
@native-api
Copy link
Member

native-api commented Feb 26, 2023

Well done! And thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants