Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing patches for Python 3.7/3.8/3.9 #2718

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

tomkins
Copy link
Contributor

@tomkins tomkins commented Jun 10, 2023

Currently when installing Python 3.7.17 on an Apple Silicon MacBook:

$ pyenv install 3.7.17
python-build: use openssl@1.1 from homebrew
python-build: use readline from homebrew
Installing Python-3.7.17...
python-build: use readline from homebrew
python-build: use zlib from xcode sdk
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/tomkins/.pyenv/versions/3.7.17/lib/python3.7/ctypes/__init__.py", line 7, in <module>
    from _ctypes import Union, Structure, Array
ModuleNotFoundError: No module named '_ctypes'
WARNING: The Python ctypes extension was not compiled. Missing the libffi lib?
Installed Python-3.7.17 to /Users/tomkins/.pyenv/versions/3.7.17

After adding the patches:

$ pyenv install 3.7.17
pyenv: /Users/tomkins/.pyenv/versions/3.7.17 already exists
continue with installation? (y/N) y
python-build: use openssl@1.1 from homebrew
python-build: use readline from homebrew
Installing Python-3.7.17...
patching file 'Doc/library/ctypes.rst'
patching file 'Lib/test/test_unicode.py'
patching file 'Modules/_ctypes/_ctypes.c'
patching file 'Modules/_ctypes/callproc.c'
patching file 'Modules/_ctypes/ctypes.h'
patching file setup.py
patching file 'Misc/NEWS.d/next/Core and Builtins/2020-06-30-04-44-29.bpo-41100.PJwA6F.rst'
patching file 'Modules/_decimal/libmpdec/mpdecimal.h'
patching file setup.py
python-build: use readline from homebrew
python-build: use zlib from xcode sdk
Installed Python-3.7.17 to /Users/tomkins/.pyenv/versions/3.7.17

I've copied across the OpenSSL patches for 1.1.1q as well, although that's untested as my current Homebrew OpenSSL is 1.1.1u.

@native-api
Copy link
Member

native-api commented Jun 10, 2023

I've copied across the OpenSSL patches for 1.1.1q as well, although that's untested as my current Homebrew OpenSSL is 1.1.1u.

Better replace the 1.1.1q reference with the latest version as of now and get rid of the patches.

@native-api native-api merged commit 687944d into pyenv:master Jun 10, 2023
27 checks passed
@tomkins tomkins deleted the missing-patches branch June 11, 2023 10:33
dand-oss pushed a commit to dand-oss/pyenv that referenced this pull request Jun 17, 2023
* Use OpenSSL 1.1.1u and remove patches for 1.1.1q
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants