Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get-pip urls for older pypy versions #2788

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Sep 15, 2023

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

On older recipes for PyPy the current get-pip.py is called, when it returns and incompatible script. Older CPython work around this by supplying the appropriate unsupported minor version number in the URL, such as https://bootstrap.pypa.io/pip/2.7/get-pip.py. This change would incorporate this same logic into PyPy installs such as pypy2.7-7.3.12 where the minor version of Python is specified.

Tests

  • Adds unittests to pyenv_ext.bats for previously untested and new pinned bootstrap script versions.

@TimPansino TimPansino marked this pull request as ready for review September 15, 2023 21:13
@TimPansino
Copy link
Contributor Author

Let me know if an accompanying issue is required and I can open one.

@native-api native-api merged commit 8cfc756 into pyenv:master Sep 16, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants