New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add miniforge and mambaforge 22.11.1-3, 22.11.1-4, 23.1.0-0 to 23.11.0-0 #2909
Add miniforge and mambaforge 22.11.1-3, 22.11.1-4, 23.1.0-0 to 23.11.0-0 #2909
Conversation
I was attempting to run the script to generate build files for new versions, but it failed because version `23.1.0-4`[^1] contained a malformed `.sha256` file.[^2] I looked at the miniforge repo's script `releases.py`[^3] and copied the logic about which release artifacts should be skipped when generating a list of downloads. [^1]: https://github.com/conda-forge/miniforge/releases/tag/23.1.0-4 [^2]: https://github.com/conda-forge/miniforge/releases/download/23.1.0-4/Miniforge3-uninstaller-patch-Windows-x86_64.exe.sha256 [^3]: https://github.com/conda-forge/miniforge/blob/a15762906ba6f339a95b218b784e91605a24a681/docs/releases.py#L35-L36
The glob pattern we were using was too permissive and detecting miniconda build scripts as miniforge build scripts when they shared the same version. I have rewritten the pattern matching code to ensure we only look at files starting with `miniforge` and `mambaforge`.
We always detect missing build scripts for `4.13.0-0` because the release[^1] doesn't have any mambaforge artifacts. Given that we've already created the build files, we don't need to check the release again. [^1]: https://github.com/conda-forge/miniforge/releases/tag/4.13.0-0
I'm not entirely sure what is causing the failures. All of them were caused by I suspect we hit a rate limit or some other sort of network-related problem. Can you rerun just the tests that failed? |
Did a rerun, same problem. |
Tested at home and got the same errors. Reported to conda/infrastructure#882 |
Cause 403s on dependency packages
f3853c3
to
57594c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we commit this without the broken versions and re-add them when they're fixed.
Is this okay for you?
Works for me! I find this problem very weird, though. I ran |
I used
add_miniforge.py
to generate definitions files for missed versions released over the past year.In addition, I realized that the script had some problems pulling all versions, so I adjusted the code accordingly.
I tested this by successfully installing and running
miniforge3-23.11.0-0
on x86_64 macOS.