Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why wrap _validate with validate and validate_update ? #21

Closed
arshsingh opened this issue Sep 23, 2013 · 1 comment
Closed

why wrap _validate with validate and validate_update ? #21

arshsingh opened this issue Sep 23, 2013 · 1 comment

Comments

@arshsingh
Copy link
Contributor

@arshsingh arshsingh commented Sep 23, 2013

if all the validate and validate_update methods do is just pass the update parameter, why not just let the user do it ?

this is much better :

validate(document)
validate(document, update=True)

than this:

validate(document)
validate_update(document)
@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Sep 23, 2013

Yes this has been under my radar for a while. Initially, I think I wanted to make sure that update-validating was a very visible option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants