Definition schema class #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the purpose of these changes was to let DefinitionSchema behave like a proper dictionary to allow safe runtime-manipulation of a schema. if such manipulation raises an exception that is handled, the previous state is retained. while working on it, i stumbled over some issues that are addressed. to have more descriptive and unambigious names: - renames ValidationError to DocumentError - renames ERROR_SCHEMA_TYPE to ERROR_SCHEMA_TYPE_TYPE - ERROR_SCHEMA_CONSTRAINT_TYPE_TYPE would be more correct - renames ERROR_SCHEMA_FORMAT to ERROR_SCHEMA_TYPE - adds a ERROR_SCHEMA_CONSTRAINT_TYPE for constraints that are not defined as mapping other: - exceptions are inherited from Exception, so they are not caught by `except ValueError`
funkyfuture
force-pushed
the
definition_schema_class
branch
2 times, most recently
from
9e1fa72
to
ac08315
Compare
|
i added some commits to purge the in-code-backlog well, more tests would be possible. :-/ |
funkyfuture
force-pushed
the
definition_schema_class
branch
4 times, most recently
from
e5e4c36
to
0b8fc4f
Compare
| @@ -51,6 +51,9 @@ matters, we can use it to validate all odd values: | |||
| >>> v.validate({'oddity': 9}) | |||
| True | |||
|
|
|||
| In a schema schema you can use space characters instead of underscores, e.g. | |||
| ``{'oddity': {'is odd': 42'}}`` is an alias for ``{'oddity': {'is odd': 42'}}``. | |||
|
Nice. Would you also update CHANGES to reflect the change from ValidationError to DocumentError, and error constants which have changed names? |
funkyfuture
force-pushed
the
definition_schema_class
branch
from
0b8fc4f
to
2e39ac9
Compare
also a little refactoring of error-messages
includes fixes: - normalizes unknown fields per `allow_unknown` - normalizes unknown fields in subdocuments - allows empty `schema`-rule-definitions
funkyfuture
force-pushed
the
definition_schema_class
branch
from
2e39ac9
to
02d8159
Compare
also removes an obsolete check when validating a dict for 'schema'-rule
|
a'ight, i added the last commits to this pr. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes a commit that improves DefinitionSchema and one that fixes an issue that came up in the doctests for the first time.