Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements excludes #137

Merged
merged 14 commits into from Aug 27, 2015
Merged

Implements excludes #137

merged 14 commits into from Aug 27, 2015

Commits on Aug 25, 2015

  1. Implements excludes

    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    e384a6b View commit details
    Browse the repository at this point in the history

  2. Factorise _validate_excludes 

    Also pass flake8 test
    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    7f26878 View commit details
    Browse the repository at this point in the history

  3. Remove leading dots in the documentation 

    They were interpreted as statement, not expected result
    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    2cbae0d View commit details
    Browse the repository at this point in the history

  4. Fix style after review 

    Namelly :

  - be consistent : name parameter `excludes` instead of `exclude`
  - if `excludes` is a string, simply wrap it in a list
  - test if `excludes` is a string with `_str_type`
    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    b163076 View commit details
    Browse the repository at this point in the history

  5. Better error string for excludes 

    Also tests
    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    7d397e9 View commit details
    Browse the repository at this point in the history

  6. Fix flake8 errors

    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    0db343e View commit details
    Browse the repository at this point in the history

  7. Test for Hashable

    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    6d56b64 View commit details
    Browse the repository at this point in the history

  8. Constraint excludes to Hashable

    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    a32942e View commit details
    Browse the repository at this point in the history

  9. Add indice to format string to pass py26

    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    2d84d1d View commit details
    Browse the repository at this point in the history

  10. Fix documentation

    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    6dfca7d View commit details
    Browse the repository at this point in the history

  11. Allow assertSuccess to take the update parameter

    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    5746872 View commit details
    Browse the repository at this point in the history

  12. Fix mutually required fields 

    Save a set of required fields, and ensure at least one of them is
present in the end
    @calve
    calve committed Aug 25, 2015
    Copy the full SHA
    7504fc8 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2015

  1. Fix attribute naming after suggestions

    @calve
    calve committed Aug 26, 2015
    Copy the full SHA
    9c4f92e View commit details
    Browse the repository at this point in the history

  2. Sort validations method alphabetically 

    Keep definition validation method sorted alphabetically
    @calve
    calve committed Aug 26, 2015
    Copy the full SHA
    fa7b7b4 View commit details
    Browse the repository at this point in the history