Fixes #251 #256
Closed
Fixes #251 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviskirk
commented
Aug 26, 2016
daviskirk
commented
- add test
|
As this wasn't really related to #250 after all I looked at this as well while I was at it. As far as I can see, this is now the intended behavior. I added a test for |
| document = {'test': {'known': 's'}} | ||
| self.validator(document, schema) | ||
| _errors = self.validator._errors | ||
| self.assertEqual(len(_errors), 1) |
There was a problem hiding this comment.
please also check that there are no child-errors.
_errors[0].child_errors
- Get rid of nonsense normalization test - Add test for child errors
|
Merged after rebase: 78704de Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.