Convert self.assert* method calls to plain asserts #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
plain-asserts
branch
from
0497a89
to
104712c
Compare
|
nice, now get rid of the classes? |
|
While I agree that the classes can be removed, I'm afraid I won't have time to do this change myself so I think that can be done in a separate PR. 😁 |
nicolaiarocci
added a commit
that referenced
this pull request
Sep 6, 2016
|
Merged after rebase. Thanks! |
|
👍 |
funkyfuture
pushed a commit
to funkyfuture/cerberus
that referenced
this pull request
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used unittest2pytest to make the conversion.