Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parser.py #61

Merged
merged 1 commit into from
Jul 24, 2015
Merged

Update parser.py #61

merged 1 commit into from
Jul 24, 2015

Conversation

terrysclaw
Copy link
Contributor

Fix UnicodeEncodeError when filtering unicode string (#58)

Fix UnicodeEncodeError when filtering unicode string (#58)
amleczko added a commit that referenced this pull request Jul 24, 2015
@amleczko amleczko merged commit 7dc3acf into pyeve:master Jul 24, 2015
@goneri
Copy link
Contributor

goneri commented Jul 24, 2015

I'm afraid this patch break Python3 support:

(...)
    r = f(resource, **combined_args)
  File "/home/goneri/git_repos/eve/eve/methods/get.py", line 105, in get
    build_response_document(document, resource, embedded_fields)
  File "/home/goneri/git_repos/eve/eve/methods/common.py", line 506, in build_response_document
    resolve_embedded_documents(document, resource, embedded_fields)
  File "/home/goneri/git_repos/eve/eve/methods/common.py", line 692, in resolve_embedded_documents
    subdocument[last_field]))
  File "/home/goneri/git_repos/eve/eve/methods/common.py", line 684, in <lambda>
    getter = lambda ref: embedded_document(ref, data_relation, field)  # noqa
  File "/home/goneri/git_repos/eve/eve/methods/common.py", line 623, in embedded_document
    **{config.ID_FIELD: reference})
  File "/home/goneri/git_repos/eve-sqlalchemy/eve_sqlalchemy/__init__.py", line 174, in find_one
    parse_dictionary(lookup, model))
  File "/home/goneri/git_repos/eve-sqlalchemy/eve_sqlalchemy/parser.py", line 45, in parse_dictionary
    if(type(v) is unicode):
NameError: name 'unicode' is not defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants