-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EntityWithHashchain.Event.__mutate__ is never called #164
Comments
Wow, well spotted! :)) you're good! |
Was producing the right answer, but accidentally. Thanks to Chan-Ho Suh for spotting the issue: #164
@chanhosuh I fixed it like this: 94ffec3 |
Tests passed so I'll close this. Please reopen if you need to. Many thanks for spotting this issue, and if you spot anything else, please don't hesitate to open another! :) |
@johnbywater that's great! I was feeling guilty about posting a sloppy issue and was planning to write a formal PR so I could run your tests etc... but you've pre-empted me :) |
I noticed that in the code for
EntityWithHashChain.Created
, thesuper
call does not put in the class ofself
, but of its parent:This means the
__mutate__
ofEntityWithHashChain.Event
is skipped. In fact, fixing the super call will make the example code in the quickstart guide fail. Probably the fix should be to remove the method.The text was updated successfully, but these errors were encountered: