test coverage improvement

pyexcel_io/csvzipbook.py

@@ -50,7 +50,7 @@ def sheet_iterator(self):
                 raise ValueError("%s cannot be found" % self.sheet_name)
             else:
                 return rets
-        elif self.sheet_index:
+        elif self.sheet_index is not None:
             file_list = self.native_book.namelist()
             length = len(file_list)
             if self.sheet_index < length:
@@ -70,10 +70,7 @@ def get_sheet(self, native_sheet):
         if PY2:
             sheet = StringIO(content)
         else:
-            if isinstance(content, str):
-                sheet = StringIO(content)
-            else:
-                sheet = StringIO(content.decode('utf-8'))
+            sheet = StringIO(content.decode('utf-8'))
 
         return CSVinMemoryReader(
             NamedContent(

test.bat

@@ -1,2 +1,2 @@
-nosetests --with-cov --cov pyexcel_io --cov tests --with-doctest --doctest-extension=.rst doc/source tests pyexcel_io
+nosetests --with-doctest --doctest-extension=.rst doc/source tests pyexcel_io
 del tmp.db

tests/test_csvz_book.py

@@ -1,5 +1,5 @@
 import os
-from pyexcel_io import CSVZipBook, CSVZipWriter, save_data, OrderedDict
+from pyexcel_io import CSVZipBook, CSVZipWriter, save_data, OrderedDict, get_io
 import zipfile
 from nose.tools import raises
 import sys
@@ -35,11 +35,24 @@ def test_reading(self):
         zipreader = CSVZipBook(self.file)
         data = zipreader.sheets()
         assert data['pyexcel_sheet1'] == [['1','2','3']]
-
+        
     def tearDown(self):
         os.unlink(self.file)
 
 
+def test_reading_from_memory():
+    data = [[1,2,3]]
+    io = get_io("csvz")
+    zipbook = CSVZipWriter(io)
+    sheet = zipbook.create_sheet(None)
+    sheet.write_array(data)
+    sheet.close()
+    zipbook.close()
+    zipreader = CSVZipBook(io)
+    data = zipreader.sheets()
+    assert data['pyexcel_sheet1'] == [['1','2','3']]
+
+
 class TestMultipleSheet:
     def setUp(self):
         self.content = OrderedDict()

tests/test_django_book.py

@@ -11,7 +11,7 @@ def __getattr__(self, field):
 
 class Objects:
     def __init__(self):
-        self.objs = None
+        self.objs = []
 
     def bulk_create(self, objs, batch_size):
         self.objs = objs
@@ -113,6 +113,12 @@ def test_mapping_dict(self):
         writer.close()
         assert model.objects.objs == self.result
 
+    def test_empty_model(self):
+        model = FakeDjangoModel()
+        reader = DjangoModelReader(model)
+        data = reader.to_array()
+        assert data == []
+
 
 class TestMultipleModels:
     def setUp(self):

tests/test_io.py

@@ -1,7 +1,7 @@
 from pyexcel_io import (
     SheetReaderBase, SheetReader, BookReader,
     SheetWriter, BookWriter, NamedContent,
-    BookReaderBase
+    BookReaderBase, SheetWriterBase
 )
 from nose.tools import raises
 
@@ -138,7 +138,11 @@ def test_load_from_memory(self):
         reader = DictReader(None, self.content)
         assert self.content == reader.sheets()      
 
-
+class TestSheetWriterBase:
+    @raises(TypeError)
+    def test_abstractness(self):
+        SheetWriterBase("test")
+
 class TestSheetWriter:
     @raises(TypeError)
     def test_abstractness(self):