🐛 fix #42: Errors should never pass silently

pyexcel · Aug 6, 2017 · a94f937 · a94f937
1 parent c2859d1
commit a94f937
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/pyexcel_io/book.py b/pyexcel_io/book.py
@@ -192,6 +192,8 @@ def write(self, incoming_dict):
             if sheet_writer:
                 sheet_writer.write_array(incoming_dict[sheet_name])
                 sheet_writer.close()
+            else:
+                raise Exception("Cannot create a sheet writer!")
 
     def create_sheet(self, sheet_name):
         """

diff --git a/pyexcel_io/database/importers/sqlalchemy.py b/pyexcel_io/database/importers/sqlalchemy.py
@@ -81,4 +81,6 @@ def create_sheet(self, sheet_name):
                 self.__importer, adapter,
                 auto_commit=self.__auto_commit
             )
+        else:
+            raise Exception("No suitable database adapter found!")
         return sheet_writer
diff --git a/tests/test_django_book.py b/tests/test_django_book.py
@@ -345,6 +345,7 @@ def test_reading_from_more_models(self):
             data[key] = list(data[key])
         assert data == self.content
 
+    @raises(Exception)
     def test_special_case_where_only_one_model_used(self):
         model1 = FakeDjangoModel()
         importer = DjangoModelImporter()