Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyfa crashes when I open character editor. #441

Closed
negatif-negatif opened this issue Nov 18, 2015 · 85 comments
Closed

pyfa crashes when I open character editor. #441

negatif-negatif opened this issue Nov 18, 2015 · 85 comments
Labels
fixed This issue has been fixed! Oh joy!

Comments

@negatif-negatif
Copy link

I just installed the latest version on win 7 ultimate edition and it crashes when I open the character editor.

@negatif-negatif
Copy link
Author

error log is empty....

@negatif-negatif
Copy link
Author

pyfa 1.16.2 stable - paralax 1.1
python: 2.7.10 [msc v.1500 32 bit (intel)]
wxPython: 3.0.2.0

@blitzmann
Copy link
Collaborator

Can you be more descriptive? Crashes how? Does the program close or just become unresponsive? Can you exit out of character editor and continue to use pyfa?

Check %USERPROFILE%/.pyfa/log.txt and let me know if you notice any information there.

Also, with the binary upgrades we defaulted to with this version, the old directory structure is now invalid and can cause problems. Usually pyfa won't even start in this case, but to be on the safe side I would uninstall pyfa and delete the directory it was installed in, and reinstall.

@negatif-negatif
Copy link
Author

screenshot127

the log files are empty.
I uninstalled, deleted directories and I reinstalled a new copy,... same thing...

and yeah.. my bad.. it does not crash.. it freezes... and if I click the window I get the 'search for a solution or close this program' window...

@blitzmann
Copy link
Collaborator

Do you mind sending me your saveddata.db file? My email is sable.blitzmann@gmail.com. I have no idea why this happens, but freezes like this can be database corruption sometimes

@blitzmann
Copy link
Collaborator

I have received the database, but it is empty. I assume you have not used pyfa before.

Honestly I am not sure what the problem is. Did you use the installer or did you download the zip? Do previous versions work? Can you try v1.15 zipfiles?

@negatif-negatif
Copy link
Author

I installed the latest versions a few days ago. I used the installer.

I had a previous version installed but I did not used it. I used eft ( :-p) until now and I was thinking of switching.

Also tried the 1.16 zip ... same thing..

..but the 1.15 zip is working.

I will try some things maybe I can figure it out and let you know.

@blitzmann
Copy link
Collaborator

Does it work otherwise? Is it just the character editor that freezes? That is so strange and I don't really have an idea at the moment <_<

But the fact that 1.15 works makes me think this is a wx3 compatibility issue. Can you try the 1.15-wx3 build and see if you have the same issue vs the regular 1.15 build?

@blitzmann
Copy link
Collaborator

I made a change, wondering if you could test it out with this test build and see if you still experience the crash:

http://eve-files.com/dl/276130

@negatif-negatif
Copy link
Author

I tested the files you sent me. same thing. I also installed the latest release.. same thing.

Below is what I see when the app crashes. Sorry I did not see this sooner. It was under a dropdown and I did not push the button until now. Could this be of any help to you:

Problem signature:
Problem Event Name: APPCRASH
Application Name: pyfa.exe
Application Version: 1.15.1.0
Application Timestamp: 549debdc
Fault Module Name: StackHash_03ad
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 00000000
Exception Code: c0000005
Exception Offset: 74c72dd9
OS Version: 6.1.7600.2.0.0.256.1
Locale ID: 1033
Additional Information 1: 03ad
Additional Information 2: 03adf476f9e9c2a62a503fbcb0935928
Additional Information 3: c3e2
Additional Information 4: c3e2562c02b0d5c0f9628ca99ca6be69

@blitzmann
Copy link
Collaborator

Hmm, I have no idea then. StackHash_03ad is where there is a problem, but I have no idea what this means - it's not something that's part of pyfa AFAIK.

Previous APPCRASH issues were solved by turning off automatic HTML export in the preferences. You could try that, but I highly doubt it's related as this happens with the character editor.

I will look into it. I may have you run pyfa through an interpreter if I can't find any solutions and see if it happen then as well./ If it comes to that, I will explain it in great detail.

@DTBA
Copy link

DTBA commented Dec 9, 2015

I would like to add my pyfa also crashes on the character editor.

It was working fine with 1.15 but 1.16 and yesterday release are both crashing?

Can I help you with anything

@DTBA
Copy link

DTBA commented Dec 9, 2015

Normal exe installer on the unzip one both do the same

capture

@blitzmann
Copy link
Collaborator

Could you guys download the 1.15 -win-wx3 version and test? This problem probably has to do with the switch to wx3.

@DTBA
Copy link

DTBA commented Dec 10, 2015

1.15 -win-wx3 download and tested. Can confirm it also crashes as soon as I open the character editor

Windows error
capture

@negatif-negatif
Copy link
Author

same here.

@DTBA
Copy link

DTBA commented Dec 14, 2015

any news or something we can do to help?

@thorr18
Copy link

thorr18 commented Dec 14, 2015

StackHash_xxxx is not a real module. It's Windows' way of labeling the issue when it's happening outside of any known module. xxxx is a stamp of what that thread's stack looked like when the problem happened. It's only useful to see that two different people are getting the same hash. It is probably triggering the Windows "DEP". Troubleshooting can involve trying to find the offending library that is wandering out of it's space, but could also include temporarily disabling DEP in Windows or temporarily disabling anti-virus (because they can actually insert code).
Thought I'd mention that, but obviously it might help to add some logging statements to the character editor and then duplicate the issue with logging on.

@blitzmann
Copy link
Collaborator

Thanks for the info @thorr18. I'm still not sure how to proceed. It's complicated by the fact that I cannot duplicate the issue myself.

I will put together a character editor file with some logging to figure out where it dies.

Does it crash immediately after opening? When does it happen?

@negatif-negatif
Copy link
Author

When you go to Window->character editor the character editor window opens. After that the window freezes, just like on the screenshot above.

Other aspect of the program work fine.

@DTBA
Copy link

DTBA commented Dec 15, 2015

Yes as soon as you open a second later it crashes you don't even touch anything

@blitzmann
Copy link
Collaborator

Can you guys add Sable Blitzmann to your watchlist in-game and message me when you see me online? I feel like real-time communication would work a lot better in troubleshooting this problem than back and forward thread posts like this.

I'm probably going to need to send files for you guys to test, and it will just be slow going through this.

@DTBA
Copy link

DTBA commented Dec 16, 2015

I will do so I would also grant you remote access via team viewer at that time. thank you

@blitzmann
Copy link
Collaborator

Can you guys open library.zip and find gui/characterEditor.py and replace the contents with this:

http://pastebin.com/AYuSViEE

You may have to copy the file out of the zip first, replace the contents save it, then copy it back into the zip overwriting the old one.

And then run pyfa again with debug and post output of the log file

@DTBA
Copy link

DTBA commented Jan 10, 2016

how do you run it with debug?

@blitzmann
Copy link
Collaborator

Sorry, thought it was already explained in this thread. Run the exe like pyfa.exe -d

@DTBA
Copy link

DTBA commented Jan 11, 2016

I might be just plain stupid or I am missing something,

So I set my launch options like this "C:\whaterver\pyfa.exe" -d

Then just open pyfa? crash it? then where do I find the log file? or must I do something else before I crash it ? can't seem to find the log file

@blitzmann
Copy link
Collaborator

The log file should be %userprofile%/.pyfa/log.txt. But yes, go ahead and crash it after replacing that file

@DTBA
Copy link

DTBA commented Jan 11, 2016

Ok so all I did on todays date was open it and crashed it log file attached.

2016-01-11 08:05:18,522 gui.characterEditor DEBUG ========== Character Editor ==========
2016-01-11 08:05:18,532 gui.characterEditor DEBUG Init character editor frame with parent:<gui.mainFrame.MainFrame; proxy of <Swig Object of type 'wxFrame *' at 0x536fee0> >
2016-01-11 08:05:18,532 gui.characterEditor DEBUG done with frame init, moving on...
2016-01-11 08:05:18,532 gui.characterEditor DEBUG creating buttons and text ctrl
2016-01-11 08:05:18,542 gui.characterEditor DEBUG getting character list:
2016-01-11 08:05:18,562 gui.characterEditor DEBUG [(1, u'All 5', True), (2, u'All 0', False), (3, u'DTBA current ', False), (4, u'New Character', False), (5, u'Dubby', False)]
2016-01-11 08:05:18,562 gui.characterEditor DEBUG looping through character action buttons
2016-01-11 08:05:18,562 gui.characterEditor DEBUG new done
2016-01-11 08:05:18,572 gui.characterEditor DEBUG rename done
2016-01-11 08:05:18,572 gui.characterEditor DEBUG copy done
2016-01-11 08:05:18,651 gui.characterEditor DEBUG delete done
2016-01-11 08:05:18,651 gui.characterEditor DEBUG adding notbook and pages
2016-01-11 08:05:18,812 gui.characterEditor DEBUG creating character saving buttons and binding them
2016-01-11 08:05:18,812 gui.characterEditor DEBUG restricting buttons
2016-01-11 08:05:18,822 gui.characterEditor DEBUG setting main sizer
2016-01-11 08:05:18,822 gui.characterEditor DEBUG .Layout()
2016-01-11 08:05:18,822 gui.characterEditor DEBUG .Center()
2016-01-11 08:05:18,822 gui.characterEditor DEBUG checking if character warrents restriction
2016-01-11 08:05:18,822 gui.characterEditor DEBUG yes, restrict: All 5
2016-01-11 08:05:18,822 gui.characterEditor DEBUG registerEvents():closeEvent
2016-01-11 08:05:18,822 gui.characterEditor DEBUG registerEvents():refreshCharacterList
2016-01-11 08:05:18,822 gui.characterEditor DEBUG registerEvents():charChanged

log.txt

@DTBA
Copy link

DTBA commented Jan 11, 2016

Did it again same LOG also attached
log.txt

@blitzmann
Copy link
Collaborator

With the "Real skills in notebook", can you give me the log output and let me know if you can see the skill groups on the GUI (or screenshot)?

Also, try these now. With these I'm trying to see if the number of tree elements has anything to do with it, or if it's more:

2 dummies, skills loaded: http://pastebin.com/KVJ5CC9Y
Lots of dummies, skills loaded: http://pastebin.com/1xar0Zzh
Limited skills: http://pastebin.com/GQZxgGyE
All skills: http://pastebin.com/6gWmU3Wp

This is getting ridiculous. But I'm really thinking it's a wxPython bug of some sort, one that we won't be able to overcome properly with the current binaries (still want to try building on a Win 7 machine and having you try that, hopefully I can get that done soonish. bear with me =)

@DTBA
Copy link

DTBA commented Jan 19, 2016

Seems its Number of skills related.

2 dummies, skills loaded: Works 100%

Lots of dummies, skills loaded: Crashes as I open Character Editor. LOG: http://pastebin.com/w0ajx0Yk Screen shot :http://i.snag.gy/4RtDE.jpg

Limited skills: Works 100%

All skills: Crashes as I open Character Editor. LOG: http://pastebin.com/e4Hd7X0S Screen: http://i.snag.gy/vWGDa.jpg

Real skills in notebook. LOG and screen shot that you asked for. http://i.snag.gy/b4ByC.jpg http://pastebin.com/yAiuL7pq

I hope the logs on paste bin is fine for you I rather do it that way then uploading logs.

Just leaving this here %userprofile%/.pyfa/log.txt Keep needing to scroll up to find it lol

@DTBA
Copy link

DTBA commented Jan 19, 2016

OK so note
groups = [(x, "Group %d"%x) for x in xrange(6)]
anything above 6 crashes it

@DTBA
Copy link

DTBA commented Jan 19, 2016

OK solved it got my pyfa to work 100% now http://i.snag.gy/9n73V.jpg

so I changed

line 60
self.navSizer.Add(self.charChoice, 1, wx.ALL | wx.EXPAND, 5)
to
self.navSizer.Add(self.charChoice, 1, wx.ALL | wx.EXPAND, 21)

@DTBA
Copy link

DTBA commented Jan 19, 2016

Please test with 1.18.0
open library.zip and find gui/characterEditor.py and replace the contents with this: http://pastebin.com/tg8ixryN

@makenshine
Copy link

Didn't crash for me.

@blitzmann
Copy link
Collaborator

While I am ecstatic that you figured out a fix, I am completely baffled. That does not make any sense to me. What you changed is essentially the border width of the character drop down. Considering the fact that we stripped all the extra bits and it still crashed when in a notebook and loaded with more than 6 items, I am not sure if this is actually fixing it or somehow masking it. Perhaps it's an issue with the Notebook widget itself..

Did you play with any other bits? If so, what were the results?

A problem with this particular fix is that it will probably break if you try to make a new character or rename.

Can I have you try this: http://pastebin.com/vHUVgyaY

This replaces the built-in notebook with pyfa's custom ChromeTabs notebook. If it's a problem with the notebook, this shouldn't crash (and allows us to keep sane border levels).

But, if all else fails, at least we have a fix (the borders of which we can probably tweak)

@makenshine
Copy link

Will try yours, but I have added new characters, renamed characters, deleted characters and readded them to test the fix. No crashes.

@makenshine
Copy link

Do I replace the same gui/charactereditor.py file with the one you linked?

@DTBA
Copy link

DTBA commented Jan 20, 2016

I will test it .

And yes I have done everything with my char editor. New,edit delete import. I tested all the stuff I can it worked 100% not one crash, I will update as soon as I used the one you linked

@DTBA
Copy link

DTBA commented Jan 20, 2016

This http://pastebin.com/vHUVgyaY crashes 100% the same way:

I will test some other thing today.

@blitzmann
Copy link
Collaborator

This is getting odder.

Frame without additional styles and min size: http://pastebin.com/LWXGnksw
Modifying nav sizer instead of dropdown: http://pastebin.com/9FiMXznX
Change frame to dialog (I'm really hopeful about this one): http://pastebin.com/cJjWVRny

@DTBA, gonna ask a favor from you. If you're uncomfortable installing additional software, I understand, don't feel obligated.

I want you to install the python interpreter and see if this issue happen when running pyfa via source. Hopefully this can tell me if it's an issue with our binaries (which I've tried to re-generate on Windows 7, but have run into trouble)

Download python 2.7.11 from here: https://www.python.org/ftp/python/2.7.11/python-2.7.11.msi

Install with default options (it will install into C:/Python27/).

Then download wxPython 3.0 from here: http://sourceforge.net/projects/wxpython/files/wxPython/3.0.2.0/wxPython3.0-win32-3.0.2.0-py27.exe/download

Install that as well with default options (it should find the python install directory)

With command prompt, do the following steps (change directory if you used different install directory)

C:\Python27\python.exe -m pip install sqlalchemy
C:\Python27\python.exe -m pip install dateutils
C:\Python27\python.exe -m pip install requests

This will install the dependencies that pyfa requires to run

Next, download the source release of pyfa (https://github.com/DarkFenX/Pyfa/releases/download/v1.18.0/pyfa-1.18.0-yc_118.1-1.0-linux.zip) and extract somewhere.

Run pyfa with C:\Python27\python.exe C:\path\to\pyfa.py -d

You should have pyfa working from the source now (with the exception of graph support, but that's not a concern for this)

Then try to replicate the issue.

You should be able to uninstall all this by running the python .msi file again and choosing to remove it (then deleting the install directory if it still exists). Keep it around for now tho, might come in handy

@DTBA
Copy link

DTBA commented Jan 20, 2016

will do and test it tomorrows :D bed time for me here! thanks for still trying to solve this bug

@blitzmann
Copy link
Collaborator

@DTBA Any luck with those test files?

@DTBA
Copy link

DTBA commented Jan 24, 2016

Sorry for the long wait. Had some family issues.
I have not download the wxPython 3.0 and all that but I have tested the files you gave.

Frame without additional styles and min size:This worked 100%
Modifying nav sizer instead of dropdown: This crashed like always
Change frame to dialog (I'm really hopeful about this one): This works but the close(top right x) and ok button does not work :?

@blitzmann
Copy link
Collaborator

Excellent. Something tangible. Seems it's an issue with the way the Frame is rendered then with some of the styles (or setting a minimum size). So very very odd, but I've never really understood why the character editor was a Frame rather than a Dialog anyway.

I'll make the switch and do some testing, watch this space for a hopefully finalized version.

Hope everything is well with you and yours, btw. I also had some family issues this weekend =(

@DTBA
Copy link

DTBA commented Jan 25, 2016

Every is ok now . Thanks for the updateing and good luck with your fam. Btw Wanted to ask I have not see the char https://github.com/blitzmann log on eve yet or we missing each other everytime

@blitzmann
Copy link
Collaborator

Nope, you haven't missed me. I haven't really logged in since the holidays due to school / work / life / Steam winter sale. Hopefully soonish I'll get back in the game

@blitzmann
Copy link
Collaborator

Hey guys, try this: http://eve-files.com/dl/276772

@blitzmann
Copy link
Collaborator

@DTBA Can you try these files as well:

SetMinSize w/o styles: http://pastebin.com/8ZCWbZW5
SetMinSize w/ styles: http://pastebin.com/Zpsgxe3s

If both those work, wonderful (make sure that you cannot reduce the size more than the default). If it doesn't work, then use the one with styles and try to delete styles of the frame one by one (the pipe character | separates the different styles) and try to figure out which one is causing the issue.

I did switch to a dialog which resolves this issue, however it spawned another issue in Linux and possible OS X. So if we can get it to work with a Frame it would be best, otherwise I'll have to go digging into why Linux and OSX are having fits.

@blitzmann
Copy link
Collaborator

@DTBA @negatif-negatif @makenshine, any news with the new test files noted in previous comment?

@DTBA
Copy link

DTBA commented Feb 4, 2016

Sorry man. Been a busy week on the farm for me.

So I am going to make time today and test them for you and get back to you!

@DTBA
Copy link

DTBA commented Feb 4, 2016

SetMinSize w/o styles: Works but if you start resizing it draging it around it crashes pyfa.(making it bigger)

SetMinSize w/ styles: This one works 100% but as soon as you close pyfa it said pyfa stopped working.

Nothing makes sense anymore :(

@blitzmann
Copy link
Collaborator

Nothing makes sense anymore :(

My thoughts exactly. I dunno if this is a manifastation of one bug or several bugs intertwines, but it's definitely a wxPython/wxWidget issue. I'll have to compile all this info at some point and get some outside help - it bothers me not know what exactly is happening lol

There is a style that we may be able to use called wx.RESIZE_BORDER, which if we remove this style from the Frame it will refuse to resize. Please try it:
http://pastebin.com/QVuGhm8Z

If that works, it's what I will go with. Otherwise, I think we will go with the no min size change, but that will be odd as you can then shrink the frame to practically nothing.

@DTBA
Copy link

DTBA commented Feb 5, 2016

^above one worked 100% for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed This issue has been fixed! Oh joy!
Projects
None yet
Development

No branches or pull requests

5 participants