Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show All Fits" option #523

Open
blitzmann opened this issue Feb 23, 2016 · 4 comments
Open

"Show All Fits" option #523

blitzmann opened this issue Feb 23, 2016 · 4 comments
Labels
enhancement This is a feature request, or an idea to enhancement a current feature

Comments

@blitzmann
Copy link
Collaborator

There has been recent interest in an option to show all fits currently stored in pyfa's database. There are three ways to accomplish this:

  • Remove the wildcard restriction. Or, simply return all fits if search query is exactly "*". This will allow all fits to be shown if needed. Easy workaround.
  • "All fits" ship group. This would require a custom group to be created (as we do with limited edition ships), and special logic would have to be hardcoded to catch when this group is selected so that we can pass the 2nd stage (hull listing) to the 3rd stage (fit listing) with a search criteria of all.
  • Button to show all fits. This could be restricted to the second view (ship groups) to shows all fits in that particular group (to cut down on the amount of fits we display at once)

Any solution will need to be tested with a database of 2000+ fits and tested on all platforms for performance issues.

@blitzmann blitzmann added the enhancement This is a feature request, or an idea to enhancement a current feature label Feb 23, 2016
@blitzmann
Copy link
Collaborator Author

After a quick hack and allowing the wildcard, 577 fits takes approx 1.5 seconds to return. If this were to happen, we would need to break the search into a new thread and incorporate some sort of waiting animation so that the GUI isn't frozen. This is still the case for stage 2 search I believe, but it's not usually noticed because db fetching is fast (see self.lpane.ShowLoading() and sMkt.getShipListDelayed(categoryID, self.stage2Callback)).

@bvelasquez
Copy link

Once you return all fits, it would be nice to add the "ship group" to the ship description (perhaps next to the date/time label). The list will be long, and scrolling to find your frigates or interceptors easier given there is no second column allowing sorting by ship group. I imagine the default sort would be by ship group?

Sorry for scope creep, but just putting it out there.

@blitzmann
Copy link
Collaborator Author

I think that type of request would be better served in option 3, where there is a button in the ship groups stage that shows all fits, instead of the hull belonging to that group.

EDIT: honestly, that''s the option that I'm leaning towards, unless someone can chime in with a better option or persuade me that they really need every single fit in the same view. >_>

@Neugeniko
Copy link
Contributor

When ccp does module tiericide, which it still is doing. It would be nice to have a all fits option so you can go thru em all and update them for the module changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature request, or an idea to enhancement a current feature
Projects
None yet
Development

No branches or pull requests

3 participants