New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n: more string annotations (mostly tooltips) #2240
Conversation
I'm currently using this command for
It's different from what we have in |
I think I moved over to explicitly stating the directories because it kept getting things in my venv (which is in my pyfa directory). But I'll update the readme with whatever it needs to be :) |
.travis.yml
Outdated
@@ -12,7 +12,7 @@ matrix: | |||
before_install: | |||
- bash scripts/setup-osx.sh | |||
install: | |||
- python3 scripts/compile_lang.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason for this change? I'm good with it, but curious what's the purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased my commits on top of scripts/compile_lang.py
import config
. I think I should re-rebase my commits then :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm... that might actually be what I needed to get the config to work in the script.will test it out tonight
I'm updating |
I'm also using a in-tree python virtualenv. It's located at Append |
…new `lang.pot` Because in-tree virtualenv folder is developer-defined, we can't really predict and provide specific commands for excluding virtualenv.
@blitzmann Hey, is there a way to re-run checks? I think It's failed because crowdin translation progress script :(. |
To rerun check, you would have to either commit to the branch again, or I can rerun them manually. I'll be taking a look at this PR today and wrapping it up for merging, sorry for the delay! |
Merging, going to figure out the build issues on the main |
This time I went for tool tip strings :). These changes also include a named placeholder for Russian translation.