Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n: more string annotations (mostly tooltips) #2240

Merged
merged 10 commits into from Aug 2, 2020
Merged

Conversation

zhaoweny
Copy link
Contributor

This time I went for tool tip strings :). These changes also include a named placeholder for Russian translation.

@zhaoweny
Copy link
Contributor Author

I'm currently using this command for xgettext:

find * -name \*.py | xgettext --from-code=UTF-8 -o locale/lang.pot -d lang -k_t -f - -s

It's different from what we have in locale/README.md. Since we now have annotation in graph/ and eos/, we can't really keep using the old find gui/ *.py -name \*.py command.

@blitzmann
Copy link
Collaborator

I think I moved over to explicitly stating the directories because it kept getting things in my venv (which is in my pyfa directory). But I'll update the readme with whatever it needs to be :)

.travis.yml Outdated
@@ -12,7 +12,7 @@ matrix:
before_install:
- bash scripts/setup-osx.sh
install:
- python3 scripts/compile_lang.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason for this change? I'm good with it, but curious what's the purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased my commits on top of scripts/compile_lang.py import config. I think I should re-rebase my commits then :).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm... that might actually be what I needed to get the config to work in the script.will test it out tonight

@zhaoweny
Copy link
Contributor Author

I'm updating locale/README.md, to include plural spec and updated find command. It will also get us ready for translation with context when we update wxpython to 4.1.0+.

@zhaoweny
Copy link
Contributor Author

zhaoweny commented Jul 27, 2020

I'm also using a in-tree python virtualenv. It's located at .env and when I use bash to run find * -name "*.py", it's automatically excluded :).

Append -not -path "path/to/venv/*" to find command should exclude the folder path/to/venv recursively.

…new `lang.pot`

Because in-tree virtualenv folder is developer-defined, we can't really predict and provide specific commands for excluding virtualenv.
@zhaoweny
Copy link
Contributor Author

zhaoweny commented Aug 1, 2020

@blitzmann Hey, is there a way to re-run checks? I think It's failed because crowdin translation progress script :(.

@blitzmann
Copy link
Collaborator

To rerun check, you would have to either commit to the branch again, or I can rerun them manually. I'll be taking a look at this PR today and wrapping it up for merging, sorry for the delay!

@blitzmann blitzmann merged commit 362d081 into pyfa-org:i18n Aug 2, 2020
@blitzmann
Copy link
Collaborator

Merging, going to figure out the build issues on the main i18n branch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants