Fleet booster refactoring #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`copy.deepcopy` was not copying the booster property of the fit for whatever reason - I blame my poor understanding of copy.
…ntext from ship browser does not.
…Selected`; now supports dragging/setting via right click.
…choice and static text
… menu is now disabled with no fit selected.
This reverts commit f7fdcfc.
This is technically a button, and acts like a button without a function. Must look into making it a proper icon and not a button.
|
I'm going to go ahead and merge this. I've tested it extensively and it has been a stable feature. Still would like to fix the button issue, but it's not too much of a priority. Since this adds a column to the database, release notes warning to backup data is probably a good idea in case shit hits the fan. |
Merged
Ebag333
added a commit
to Ebag333/Pyfa
that referenced
this pull request
Apr 16, 2017
Enhancement: Allow additional overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request satisfies issue #51: it adds a better way to apply boosters to fits. Features include:
self.fleet, and simply loops to apply UI elements. This has the benefit of removing some redundancy and allowing quick changes to take place in the future.When a fit is applied, the dropdown is replaced with static text of the fit's name. Double click removes the fit as a booster, and displays the drop down again. This is so that we can support dragging non-flagged ships to the window without adding them to the dropdown.
I've tested this extensively today. The DB schema migration works for v1.1.21 databases and most likely for all previous versions. '''However''', I would like this to be tested by a few other people is possible.
Issues:
sfBrowserItem.pyto get it to not move on Mouse Click and whatnot, to simply acts as an icon, but didn't get very far. Would love for someone to look more into this, as right now people might thinks it's a button that's supposed to do something but doesn't.Pictures:
Showing new option in fitting context menu, along with new booster button/icon
Showing new fleet view, with drop downs. Wing commander is currently being applied, and I am selecting a new squad commander with the drop down which is filled with flagged fits. Note: you can still drag/right click fits to add them as boosters: (shows fit ID for debugging issues - removed in actual commit)
