Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: Total dps tanked #923

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IndictionEve
Copy link
Contributor

Added tool tips to the reinforced labels which show the total tankable HP based on the capacitor available time (HP/s * CapLastTime).

Example

The tooltip is only available if the fitting is not capstable.

This tool tip makes it much easier to compare passive tanked ships vs active tanked ships.
Additionally I added some more text to the "passive tank" tool tip.

@Ebag333
Copy link
Contributor

Ebag333 commented Dec 30, 2016

I'm not sure that this really is a stat we should be exposing.

This tool tip makes it much easier to compare passive tanked ships vs active tanked ships.
I don't think that people compare active vs passive tanked ships this way. Most people I know look at the buffer for passive ships, active tanked ships are used primarily for small gang PvP where you can tank up to a certain DPS number.

Ancil reppers can be used for buffer, but we already expose that number.

The number that you get for how long cap lasts is a bit garbage anyway. Unless it's generated by being completely neuted out, you can run your repper long after you hit that number. That's why lots of folks only shoot for 2-3 minutes cap times, they know that they can run stuff afterwards, you just can't run it full out.

There are also issues with the cap time and repper HP/s generated, because bad assumptions are made currently. Like assuming that ancil reppers have a 10s reload time (it's 60).

You can look at #812 where I call out a number of these issues.

I think it's an interesting idea, but not one that matches the way numbers are generally used, and shows a number that won't match up to actual in game numbers. I think that it will cause more confusion than it clears up.

@blitzmann
Copy link
Collaborator

@IndictionEve just FYI, since I haven't commented yet, I've been waiting on this until we get some new code related to this issue in the dev branch, then I'll evaluate this one. Thanks, and sorry for the delay!

@Gochim
Copy link
Contributor

Gochim commented Oct 30, 2019

@blitzmann Hi, I'm opening another grave, even deeper that the previous one, I know :)

Were there any updates regarding this issue?

@Marzhin971
Copy link

If this feature is added, it would be more relevant to name it "Total tanked Damage" or "Total tanked EHP", "Total" and "DPS" are mutually exlclusive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants