Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #533 #534

Merged
merged 3 commits into from Apr 25, 2024
Merged

Fix #533 #534

merged 3 commits into from Apr 25, 2024

Conversation

artpelling
Copy link
Contributor

@artpelling artpelling commented Feb 1, 2024

Closes #533

@artpelling artpelling changed the title Fix #553 Fix #533 Feb 1, 2024
Copy link
Member

@mberz mberz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing.
I'm a bit unsure though about the implicit and arbitrary selection of a single value from an array here. I think I'd prefer if this is a bit more verbose, otherwise users might assume that multi-rate signals are supported.
Could your maybe add a warning?
Also I was thinking if this could additionally check if the array is longer than a single entry and raise an exception in this case.

@f-brinkmann
Copy link
Member

Could your maybe add a warning? Also I was thinking if this could additionally check if the array is longer than a single entry and raise an exception in this case.

Maybe it's sufficient to raise an exception if there are more then one entry and convert silently otherwise?

@mberz
Copy link
Member

mberz commented Apr 3, 2024

I'd also be okay with that.

@pingelit
Copy link
Contributor

pingelit commented Apr 5, 2024

Thanks for the effort, I agree with the suggestion by f-brinkmann to to raise an exception if there are more than one entry.

@artpelling artpelling requested a review from mberz April 20, 2024 10:59
@mberz mberz merged commit 09ec1ab into pyfar:develop Apr 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants