Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/read_comsol: allow [,],- in expressions #535

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Hotfix/read_comsol: allow [,],- in expressions #535

merged 4 commits into from
Feb 16, 2024

Conversation

sikersten
Copy link
Member

Changes proposed in this pull request:

  • allow characters [, ], and - in expressions for read_comsol
  • added missing characters to regular expressions
  • added test file

@sikersten sikersten added hot For bugs on the master branch io labels Feb 2, 2024
@sikersten sikersten self-assigned this Feb 2, 2024
@github-actions github-actions bot added this to In progress in Code Backlog Feb 2, 2024
Code Backlog automation moved this from In progress to Reviewer approved Feb 6, 2024
@mberz mberz merged commit ca916f5 into main Feb 16, 2024
8 checks passed
Code Backlog automation moved this from Reviewer approved to Done Feb 16, 2024
@mberz mberz added the v0.6.4 label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahms5 ahms5 ahms5 approved these changes

@mberz mberz Awaiting requested review from mberz

@pingelit pingelit Awaiting requested review from pingelit

@f-brinkmann f-brinkmann Awaiting requested review from f-brinkmann

Assignees

@sikersten sikersten

Labels
hot For bugs on the master branch io v0.6.4
Projects
Code Backlog
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikersten @ahms5 @mberz