Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace old naming convention description #544

Merged
merged 2 commits into from
Mar 12, 2024
Merged

replace old naming convention description #544

merged 2 commits into from
Mar 12, 2024

Conversation

ahms5
Copy link
Member

@ahms5 ahms5 commented Feb 21, 2024

Changes proposed in this pull request:

  • fix concepts explaination

@ahms5 ahms5 added documentation Everything related to docstrings and comments bug For bugs not on the master branch coordinates v0.6.5 labels Feb 21, 2024
f-brinkmann
f-brinkmann approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@f-brinkmann f-brinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching :)

pingelit
pingelit requested changes Feb 23, 2024
View reviewed changes
pyfar/_concepts/coordinates.py Outdated Show resolved Hide resolved
@ahms5 @sikersten
coordinates.py aktualisieren
162556d 
Co-authored-by: sikersten <70263411+sikersten@users.noreply.github.com>
@ahms5 ahms5 requested review from pingelit and sikersten March 4, 2024 10:02
@mberz mberz merged commit 8e8343c into main Mar 12, 2024
8 checks passed
@mberz mberz deleted the fix/doc_coords branch March 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberz mberz mberz approved these changes

@f-brinkmann f-brinkmann f-brinkmann approved these changes

@sikersten sikersten sikersten approved these changes

@xefonon xefonon Awaiting requested review from xefonon

@pingelit pingelit Awaiting requested review from pingelit

Assignees
No one assigned
Labels
bug For bugs not on the master branch coordinates documentation Everything related to docstrings and comments v0.6.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahms5 @mberz @pingelit @f-brinkmann @sikersten