Test find impulse response delay complex #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tluebeck
requested review from
f-brinkmann,
ahms5,
mberz and
sikersten
and removed request for
f-brinkmann and
ahms5
ahms5
requested changes
Apr 10, 2024
pyfar/classes/audio.py
Outdated
| if self._complex and fft_norm == "rms": | ||
| raise ValueError(("'rms' normalization is not valid for " | ||
| "complex time signals")) | ||
| if self._complex and fft_norm in ["rms", "power"]: |
There was a problem hiding this comment.
This is part of #567 - should be fixe after that one is merged...
pyfar/classes/audio.py
Outdated
| @@ -957,8 +957,8 @@ def fft_norm(self, value): | |||
| raise ValueError(("Invalid FFT normalization. Has to be " | |||
| f"{', '.join(self._VALID_FFT_NORMS)}, but found " | |||
| f"'{value}'")) | |||
| if self._complex and value == "rms": | |||
| raise ValueError(("'rms' normalization is not valid for " | |||
| if self._complex and value in ["rms", "power"]: | |||
f-brinkmann
requested changes
Apr 12, 2024
pyfar/dsp/dsp.py
Outdated
| for ch in np.ndindex(impulse_response.cshape): | ||
| # Calculate the correlation between the impulse response and its | ||
| # minimum phase equivalent. This requires a minimum phase equivalent | ||
| # in the strict sense, instead of the appriximation implemented in | ||
| # pyfar. | ||
| n_samples = impulse_response.n_samples | ||
| for idx, mode in zip(range(0, len(modes)), modes): |
There was a problem hiding this comment.
This looks better
Suggested change
| for idx, mode in zip(range(0, len(modes)), modes): | |
| for idx, mode in enumerate(modes): |
There was a problem hiding this comment.
I think we need all these changes, see the discussion in slack:
We want to calculate the delay independently for real and imaginary part, and return the minimum of both. I don't see a more elegant way.
f-brinkmann
approved these changes
Apr 15, 2024
ahms5
approved these changes
Apr 17, 2024
Base automatically changed from
complex_deconvolution
to
develop_complex_signals
April 25, 2024 14:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #
Changes proposed in this pull request: