Tiled rendering #473
Merged
Tiled rendering #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guidow, you ready for a review of this? |
|
Yes, this is ready for review now. |
| task.priority = job.priority | ||
| db.session.add(task) | ||
| if num_tiles: | ||
| for tile in range(0, num_tiles - 1): |
There was a problem hiding this comment.
Use the appropriate range so we get a generator:
try:
range_ = xrange
except NameError:
range_ = rangeAlso, you don't need to include the starting 0.
|
Seems generally ok and much simpler than I guess I was expecting. I thought it might be beneficial to offer two modes of tiling, one where the jobtype on the agent determines how to tile the image and another where the user can. But...this setup will probably work fine and it's not like we couldn't include something more customizable later. |
guidow
force-pushed
the
tiled_rendering
branch
2 times, most recently
from
e8bb5a8
to
7dba203
Compare
instead of x / y values. After some deliberation, it seems more useful to leave the exact splitting of frames into regions to the jobtype. The resulting regions may even be non-uniform, which could allow users to render the parts the deem most important first.
|
I've rebase this branch to master to make it mergable again. |
|
Any more objections to merging this? |
|
Nope none, sorry for the delay got caught up on another project. Merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.