Major rewrite #43
Major rewrite #43
Conversation
src/de.rs
Outdated
| 0x5c...0x5e => Err(self.error(ErrorCode::UnassignedCode)), | ||
| 0x5f => self.parse_indefinite_bytes(visitor), | ||
|
|
||
| /// Major type 3: a text string |
src/de.rs
Outdated
| self.read.peek().map_err(Error::io) | ||
| } | ||
|
|
||
| fn eat(&mut self) { |
There was a problem hiding this comment.
Maybe fn consume like in BufReader?
src/error.rs
Outdated
| Error::__Nonexhaustive => unreachable!(), | ||
| match self.0.code { | ||
| ErrorCode::Io(ref err) => error::Error::description(err), | ||
| _ => "JSON error", |
|
Looks fantastic! Maybe 1.0 after these changes? If so, maybe we can get rid of unmaintained on the crate description after 1.0 as it really scares everybody? |
If I can find a trustworthy person wanting to maintain the crate the unmaintained can be removed. dtolnay rejected the idea to move the crate to the @serde-rs organization so it can't probably become an official serde crate. Maybe @sfackler wants to adopt the crate but he did not say so yet. (If no one is found to adopt the crate we can discuss to make the unmaintained label smaller as most long-standing issues are resolved with this rewrite and I will still review issues and PRs) |
|
Yeah, I'd be happy to adopt the crate if that'd help with things! The other big change that I'd want to make before a 1.0 is to overhaul Value to more fully support everything in CBOR. There are some tricks that the toml crate pulled with TOML datetime values that we can hopefully use here to get tags and things like that out in a useable way. |
|
Updated! |
This commit consists of a rewrite of basically all of the serialization and deserialization logic. The API and internals are based heavily off of serde_json, in particular, the error type and support for borrowed deserialization. The deserialization logic is now based off of the tag byte lookup table described in appendix B of RFC 7049. It's a bit more verbose, but compiles down to a jump table so there should be some decent performance benefits in deserialization. It should also resolve some longstanding correctness issues with deserialization of indefinite length maps and sequences. The packed encoding can now properly handle conditionally skipped fields and doesn't need special logic on the deserialization side due to new serde features. Closes pyfisch#37 Closes pyfisch#36 Closes pyfisch#32 Closes pyfisch#31
Also make sure we're testing from_reader as well as from_slice
|
Thanks a lot! |
|
This is great work. I think the readme unmaintained alert will throw a lot of people off though, maye remove it? |
This commit consists of a rewrite of basically all of the serialization
and deserialization logic. The API and internals are based heavily off
of serde_json, in particular, the error type and support for borrowed
deserialization. The deserialization logic is now based off of the tag
byte lookup table described in appendix B of RFC 7049. It's a bit more
verbose, but compiles down to a jump table so there should be some
decent performance benefits in deserialization. It should also resolve
some longstanding correctness issues with deserialization of indefinite
length maps and sequences. The packed encoding can now properly handle
conditionally skipped fields and doesn't need special logic on the
deserialization side due to new serde features.
Closes #37
Closes #36
Closes #32
Closes #31