Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change LinearBucketEncoder's Linear layer to column-wise #30

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Conversation

kaidic
Copy link
Contributor

@kaidic kaidic commented Aug 24, 2023

No description provided.

torch_frame/nn/encoder/stype_encoder.py Outdated Show resolved Hide resolved
torch_frame/nn/encoder/stype_encoder.py Outdated Show resolved Hide resolved
torch_frame/nn/encoder/stype_encoder.py Show resolved Hide resolved
torch_frame/nn/encoder/stype_encoder.py Outdated Show resolved Hide resolved
torch_frame/nn/encoder/stype_encoder.py Outdated Show resolved Hide resolved
Copy link
Contributor

@weihua916 weihua916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaidic kaidic merged commit bee5481 into master Aug 24, 2023
9 checks passed
@kaidic kaidic deleted the ple_fix branch August 24, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants