data.LightningData module

[rusty1s]

No description provided.

[codecov-commenter]

Codecov Report

Merging #3613 (d19ccb9) into master (e8915ad) will decrease coverage by 0.18%.
The diff coverage is 54.50%.

@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
- Coverage   81.66%   81.47%   -0.19%     
==========================================
  Files         294      294              
  Lines       14655    14732      +77     
==========================================
+ Hits        11968    12003      +35     
- Misses       2687     2729      +42     

Impacted Files	Coverage Δ
torch_geometric/loader/hgt_loader.py	92.50% <ø> (+2.02%)	⬆️
torch_geometric/data/lightning_datamodule.py	25.66% <25.66%> (ø)
torch_geometric/loader/dataloader.py	80.55% <63.63%> (-2.78%)	⬇️
torch_geometric/loader/neighbor_loader.py	95.34% <95.89%> (+4.43%)	⬆️
torch_geometric/data/__init__.py	100.00% <100.00%> (ø)
torch_geometric/loader/utils.py	88.52% <100.00%> (-0.37%)	⬇️
torch_geometric/typing.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8915ad...d19ccb9. Read the comment docs.

[Padarn]

Sorry to ask in a kind of random place, just trying to track down the MR which added these - I don't understand why it is required

[rusty1s]

This is required for PyTorch Lightning as it will try to re-create a given DataLoader instance for every GPU process (by calling its __init__ function). As such, collate_fn (an attribute of the DataLoader) is now present in kwargs.

[Padarn]

Cool got it!

…

On Fri, 11 Mar 2022, 5:38 pm Matthias Fey, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In torch_geometric/loader/neighbor_loader.py <#3613 (comment)> : > if 'dataset' in kwargs: del kwargs['dataset'] + if 'collate_fn' in kwargs: This is required for PyTorch Lightning as it will try to re-create a given DataLoader instance for every GPU process (by calling its __init__ function). As such, collate_fn (an attribute of the DataLoader) is now present in kwargs. — Reply to this email directly, view it on GitHub <#3613 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRPN5LP26RM55FIGCJ4NDU7MICJANCNFSM5JELQ22Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

-- By communicating with Grab Inc and/or its subsidiaries, associate companies and jointly controlled entities (“Grab Group”), you are deemed to have consented to the processing of your personal data as set out in the Privacy Notice which can be viewed at https://grab.com/privacy/ <https://grab.com/privacy/> This email contains confidential information and is only for the intended recipient(s). If you are not the intended recipient(s), please do not disseminate, distribute or copy this email Please notify Grab Group immediately if you have received this by mistake and delete this email from your system. Email transmission cannot be guaranteed to be secure or error-free as any information therein could be intercepted, corrupted, lost, destroyed, delayed or incomplete, or contain viruses. Grab Group do not accept liability for any errors or omissions in the contents of this email arises as a result of email transmission. All intellectual property rights in this email and attachments therein shall remain vested in Grab Group, unless otherwise provided by law.