Bug Fix: Order of transforms in label_prop example #3639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example doesn't work properly as currently written. The correct way is to reverse the order of transformations, such that we first convert the graph to undirected, then get the sparse representation.
Empirically, try running this file with the transformations listed both ways for 50 iterations, and it becomes clear from the results that the original implementation is incorrect.
Submitted for extra credit in CS224W