New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docstring for shape info #3697
Conversation
fix out channels description
Codecov Report
@@ Coverage Diff @@
## master #3697 +/- ##
=======================================
Coverage 81.68% 81.68%
=======================================
Files 295 295
Lines 14893 14898 +5
=======================================
+ Hits 12165 12170 +5
Misses 2728 2728
Continue to review full report at Codecov.
|
Thanks for the corrections. Indeed, I was also wondering how to solve some inconsistencies in notation. So I guess now all features are F instead of H. How about the attention heads? Some papers refer to them as K (like GAT) some others to H. Do you think it would be better to follow the original article of to use a universal notation in PyG? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you :)
I further changed the CSS layout and made some style changes.
I think it's better to have a universal notation, and I like the following:
|
I have another batch of the updated docstring. Is it possible to reopen this pull request or do I make a new one? |
Please send a new one if possible :) |
As proposed in #3573, here is my take on the first chunk of convolutional layers in PyG. More will follow soon.