Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add init arguments in AddSelfLoops #3702

Merged
merged 7 commits into from Dec 15, 2021
Merged

Add init arguments in AddSelfLoops #3702

merged 7 commits into from Dec 15, 2021

Conversation

dongkwan-kim
Copy link
Contributor

This PR makes the AddSelfLoops transform can use full features of the add_self_loops method.

  • choose the name of edge weights/features
  • use fill_value in add_self_loops

rusty1s
rusty1s approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I only have some minor suggestions :)

torch_geometric/transforms/add_self_loops.py Outdated Show resolved Hide resolved
torch_geometric/transforms/add_self_loops.py Outdated Show resolved Hide resolved
torch_geometric/transforms/add_self_loops.py Outdated Show resolved Hide resolved
dongkwan-kim and others added 3 commits December 15, 2021 23:51
@dongkwan-kim @rusty1s
Update torch_geometric/transforms/add_self_loops.py
f3e4816 
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@dongkwan-kim @rusty1s
Update torch_geometric/transforms/add_self_loops.py
d891a4c 
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@dongkwan-kim @rusty1s
Update torch_geometric/transforms/add_self_loops.py
abb3211 
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@dongkwan-kim
Copy link
Contributor Author

This looks really great. Thank you! 😄

@rusty1s
Copy link
Member

rusty1s commented Dec 15, 2021

I need to thank you :)

@rusty1s rusty1s merged commit b63ea43 into pyg-team:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dongkwan-kim @rusty1s