Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove size parameter for GATv2 and HEAT #3744

Merged
merged 2 commits into from Dec 22, 2021
Merged

Conversation

saiden89
Copy link
Contributor

@saiden89 saiden89 commented Dec 21, 2021

As proposed in #3713, this PR removes the size argument from the forward methods of the two classes and edits the tests to pass accordingly.

p.s. PR #3743 was forked from the wrong branch. Sorry for the inconvenience :(

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #3744 (86c16f6) into master (95ef04f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3744      +/-   ##
==========================================
- Coverage   81.79%   81.79%   -0.01%     
==========================================
  Files         299      299              
  Lines       15099    15097       -2     
==========================================
- Hits        12350    12348       -2     
  Misses       2749     2749              
Impacted Files Coverage Δ
torch_geometric/nn/conv/gatv2_conv.py 91.81% <100.00%> (-0.15%) ⬇️
torch_geometric/nn/conv/heat_conv.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ef04f...86c16f6. Read the comment docs.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s merged commit d47d9cd into pyg-team:master Dec 22, 2021
@saiden89 saiden89 deleted the delete_size branch December 22, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants