Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dev requires #3803

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Conversation

Cho-Geonwoo
Copy link
Contributor

Since the pre-commit hook is only used in the development, I added a dev_requires mode installation for developing pytorch_geometric.

How do you think about it?

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #3803 (49da90f) into master (df182ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3803   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files         299      299           
  Lines       15153    15153           
=======================================
  Hits        12393    12393           
  Misses       2760     2760           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df182ad...49da90f. Read the comment docs.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I absolutely love it. Thanks for setting this up.

CONTRIBUTING.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Cho-Geonwoo and others added 3 commits January 5, 2022 09:57
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@Cho-Geonwoo
Copy link
Contributor Author

I absolutely love it. Thanks for setting this up.

Thanks for your comments too!! 👍 👍

@rusty1s rusty1s merged commit 0ce9bf6 into pyg-team:master Jan 5, 2022
@Cho-Geonwoo Cho-Geonwoo deleted the add-dev-requires branch January 5, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants