Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_edge_attr in case num_edges == 1 #3880

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix is_edge_attr in case num_edges == 1 #3880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions torch_geometric/data/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,13 +461,11 @@ def is_edge_attr(self, key: str) -> bool:
value = self[key]
cat_dim = self._parent().__cat_dim__(key, value, self)

num_nodes, num_edges = self.num_nodes, self.num_edges
num_edges = self.num_edges
if not isinstance(value, Tensor):
return False
if value.size(cat_dim) != num_edges:
return False
if num_nodes != num_edges:
return True
return 'edge' in key


Expand Down